Adds #17685 better warning for bulk status change to undeployable type #18162
+37
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Godmartinz
changed the title
Member
|
This seems like a weird solution tho. "That asset" when you're referring to something done in bulk seems confusing and potentially misleading. |
Member
Author
|
Translation and image in description has been updated 👍 |
snipe
requested changes
Nov 20, 2025
| $("#assignto_selector").hide(); | ||
| $("#selected_status_status").removeClass('text-success'); | ||
| $("#selected_status_status").addClass('text-danger'); | ||
| $("#selected_status_status").html('<x-icon type="warning" /> {{ trans_choice('admin/hardware/form.asset_not_deployable_checkin', 2) }} '); |
Member
There was a problem hiding this comment.
This will cause a syntax error if the translation contains an apostrophe - probably want to use double-quotes here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if an undeployable status type is selected, we double down on the warning that no changes will be applied to the status of the selected items.